refactor: try to reduce amount of http2 specific logic #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metcoder95 can you help me figure out why this change breaks tests? |
|
Sure thing, I'll take a look; sorry for being quite slow has been busy lately 🙇 |
|
@metcoder95 some more changes, I think you get the gist |
ronag
force-pushed
the
http2-http
branch
2 times, most recently
from
c0d2eae to
45803d6
Compare
metcoder95
reviewed
Feb 23, 2024
ronag
commented
Feb 23, 2024
ronag
commented
Feb 23, 2024
Comment on lines
+1131
to
+1132
| util.destroy(this, err) | ||
| util.destroy(socket, err) |
There was a problem hiding this comment.
Suggested change
| util.destroy(this, err) | |
| util.destroy(socket, err) | |
| this.destroy(err) | |
| socket.destroy(err) |
ronag
added a commit
that referenced
this pull request
Feb 25, 2024
Steps towards more clean separation between h1 and h2. Refs: #2816
7 tasks
|
do you want me to wait for #2839 to land? |
Sorry for that one. Just got an idea and went with it. Hopefully didn't cause you unnecessary work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status