Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terminate the process correctly #2499

Closed
wants to merge 10 commits into from
Closed

fix: terminate the process correctly #2499

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bc3f16c
fix: terminate the process correctly
tsctx Dec 5, 2023
a8add52
fixup
tsctx Dec 5, 2023
ba9434a
Merge remote-tracking branch 'origin' into fix/terminate-the-process-…
tsctx Dec 5, 2023
3a88ec7
refactor
tsctx Dec 5, 2023
0faa01f
fix: handle promise
tsctx Dec 5, 2023
15185ee
Merge remote-tracking branch 'origin' into fix/terminate-the-process-…
tsctx Dec 7, 2023
7491971
fixup
tsctx Dec 7, 2023
8486c18
test: add
tsctx Dec 8, 2023
dc1aa4b
fix: test
tsctx Dec 8, 2023
b126e91
Merge remote-tracking branch 'origin' into fix/terminate-the-process-…
tsctx Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/fetch/body.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,8 @@ function cloneBody (body) {
const out2Clone = structuredClone(out2, { transfer: [out2] })
// This, for whatever reasons, unrefs out2Clone which allows
// the process to exit by itself.
const [, finalClone] = out2Clone.tee()
const [finalClone, final2Clone] = out2Clone.tee()
final2Clone.cancel().catch(() => null)

// 2. Set body’s stream to out1.
body.stream = out1
Expand Down
Loading