fix: Client.stream writableNeedDrain

Fixes: #441 Refs: nodejs/node#35348 Refs: nodejs/node#35341
nodejs · Sep 25, 2020 · cd2e352 · cd2e352
1 parent 4208071
commit cd2e352
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/lib/client-stream.js b/lib/client-stream.js
@@ -109,6 +109,12 @@ class StreamHandler extends AsyncResource {
     })
 
     this.res = res
+
+    const needDrain = res.writableNeedDrain !== undefined
+      ? res.writableNeedDrain
+      : res._writableState && res._writableState.needDrain
+
+    return needDrain
   }
 
   onData (chunk) {

diff --git a/lib/core/client.js b/lib/core/client.js
@@ -535,7 +535,9 @@ class Parser extends HTTPParser {
     }
 
     try {
-      request.onHeaders(statusCode, headers, statusCode < 200 ? null : socket[kResume])
+      if (request.onHeaders(statusCode, headers, statusCode < 200 ? null : socket[kResume]) === false) {
+        socket[kPause]()
+      }
     } catch (err) {
       util.destroy(socket, err)
       return 1

diff --git a/lib/core/request.js b/lib/core/request.js
@@ -117,7 +117,7 @@ class Request {
 
     clearRequestTimeout(this)
 
-    this[kHandler].onHeaders(statusCode, headers, resume)
+    return this[kHandler].onHeaders(statusCode, headers, resume)
   }
 
   onBody (chunk, offset, length) {