Skip to content
This repository was archived by the owner on May 13, 2019. It is now read-only.

Commit

Permalink
src: reduce patches required to build coverage
Browse files Browse the repository at this point in the history
Now that we have the --coverage option landed in
core we can remove some of the patches for node.gyp

PR-URL: #40
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
mhdawson committed Nov 9, 2016
1 parent ec151b9 commit 387677c
Showing 1 changed file with 2 additions and 17 deletions.
19 changes: 2 additions & 17 deletions coverage/patches.diff
Original file line number Diff line number Diff line change
Expand Up @@ -76,32 +76,17 @@ index 000000000000..666939bc3389
+
+exports.setup = setup;
diff --git a/node.gyp b/node.gyp
index 05a5530a2b14..fb8f865efe8a 100644
index 2254a6e..2e91bd9 100644
--- a/node.gyp
+++ b/node.gyp
@@ -80,6 +80,7 @@
@@ -86,6 +86,7 @@
'lib/internal/process/promises.js',
'lib/internal/process/stdio.js',
'lib/internal/process/warning.js',
+ 'lib/internal/process/write-coverage.js',
'lib/internal/process.js',
'lib/internal/readline.js',
'lib/internal/repl.js',
@@ -479,7 +480,13 @@
[ 'OS=="freebsd" or OS=="linux"', {
'ldflags': [ '-Wl,-z,noexecstack',
'-Wl,--whole-archive <(V8_BASE)',
- '-Wl,--no-whole-archive' ]
+ '-Wl,--no-whole-archive',
+ '--coverage',
+ '-g',
+ '-O0' ],
+ 'cflags': [ '--coverage',
+ '-g',
+ '-O0' ]
}],
[ 'OS=="sunos"', {
'ldflags': [ '-Wl,-M,/usr/lib/ld/map.noexstk' ],
diff --git a/test/common.js b/test/common.js
index 5aefdc3bcee5..750c134d33ab 100644
--- a/test/common.js
Expand Down

0 comments on commit 387677c

Please sign in to comment.