Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing yaml blocks #31

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Fix parsing yaml blocks #31

merged 2 commits into from
Jul 12, 2022

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jul 12, 2022

cclauss
cclauss approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@cclauss cclauss merged commit be6dd6a into nodejs:main Jul 12, 2022
@MoLow MoLow deleted the fix-yaml-block branch July 12, 2022 13:23
@richardlau
Copy link
Member

@cclauss Are you familiar with how new versions of tap2junit get published? I think we'd need a version containing this so I can rerun our Ansible scripts on Node.js' CI machines to pick up this fix.

@F3n67u
Copy link
Member

F3n67u commented Jul 12, 2022

fast turn around. Thanks for the fix.

@cclauss
Copy link
Collaborator

cclauss commented Jul 12, 2022 •
edited
Loading

Yes. I will try to push to PyPI tonight. https://pypi.org/project/tap2junit

@MoLow MoLow mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_runner_describe_it failures break TAP output
5 participants
@MoLow @richardlau @F3n67u @cclauss @benjamingr