-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apache License, Version 2.0 #20
Conversation
LICENSE
Outdated
same "printed page" as the copyright notice for easier | ||
identification within third-party archives. | ||
|
||
Copyright [yyyy] [name of copyright owner] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as I know it's only this bit, from here down, that needs to be included. I don't know what year it should be, or who the copyright owner should be, maybe that's @jbergstroem since it's his original code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the URL in the commit message: Copyright 2019, Red Hat, Inc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through several of the https://github.com/apache projects as well as several of the open source projects of my employer (https://github.com/IBM) and in all cases, if there was a Apache LICENSE
file then that file contained the full text of the license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same "printed page" as the copyright notice for easier | ||
identification within third-party archives. | ||
|
||
Copyright 2019 Red Hat, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, this should go back to what it used to say, it doesn't make sense in this context. for reference, the original apache: https://github.com/apache/httpd/blob/trunk/LICENSE#L189
Just leaving the whole file in verbatim is fine, deleting the appendex, line 178 and on down, would be OK, but why look for more work, and Apache itself left it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what it looks like when the directions in the appendix are followed:
Lines 1 to 15 in dab991d
# Copyright 2019, Red Hat, Inc. | |
# | |
# Licensed under the Apache License, Version 2.0 (the "License"); | |
# you may not use this file except in compliance with the License. | |
# You may obtain a copy of the License at | |
# | |
# http://www.apache.org/licenses/LICENSE-2.0 | |
# | |
# Unless required by applicable law or agreed to in writing, software | |
# distributed under the License is distributed on an "AS IS" BASIS, | |
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
# See the License for the specific language governing permissions and | |
# limitations under the License. | |
# | |
# Author: Josef Skladanka <jskladan@redhat.com> |
Hello there, This is an open PR for a long time and since I'm planned to use this tool in my project, I'll be more comfortable to have a clear LICENCE disclosure. Can I do something to make this land ? |
Let me know what I can do to help this move forward |
@cclauss ping |
Upstream has relicensed to Apache License, Version 2.0 so we add that LICENSE file.
Also see: nodejs/admin#413
@nodejs/python