-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reference for bug bounty program for node core #169
Conversation
README.md
Outdated
@@ -52,6 +52,13 @@ security activities for Node.js core but relies on the Node.js Security Working | |||
Group to recommend and help maintain policies and procedures for that | |||
management. | |||
|
|||
### Node.js Bug Bounty Program | |||
|
|||
The Node.js project engages in an official bug bounty program for security researches and responsible public disclosures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
researches -> researchers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
README.md
Outdated
|
||
The Node.js project engages in an official bug bounty program for security researches and responsible public disclosures. | ||
|
||
The program is managed through the HackerOne platform at [https://hackerone.com/nodejs](https://hackerone.com/nodejs) with further details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe ...platform. You can find more details on this page: [https...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean this?
The program is managed through the HackerOne platform.
You can find more details on this page: https://hackerone.com/nodejs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of nits
README.md
Outdated
@@ -52,6 +52,13 @@ security activities for Node.js core but relies on the Node.js Security Working | |||
Group to recommend and help maintain policies and procedures for that | |||
management. | |||
|
|||
### Node.js Bug Bounty Program | |||
|
|||
The Node.js project engages in an official bug bounty program for security researches and responsible public disclosures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
researches -> researchers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, @mhdawson beat me to it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
README.md
Outdated
|
||
The Node.js project engages in an official bug bounty program for security researches and responsible public disclosures. | ||
|
||
The program is managed through the HackerOne platform at [https://hackerone.com/nodejs](https://hackerone.com/nodejs) with further details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the URL is the same as the text, how about just putting it in angle brackets like:
the HackerOne platform at <https://hackerone.com/nodejs>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other places we just use the URL so I'll change it to plain text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a suggestion.
@mhdawson can you check my reply to your suggestion, I'm not sure I understood it. |
We should wait to land this until we clarify if/when core will start using Hacker one for reporting. |
@lirantal should be good to land now :-) |
Also submitted nodejs/nodejs.org#1627 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes! Awesome and thanks @reedloden for PRing to the website 👏 |
Anyone want to send me a check for my path REDOS disclosures? ;-) |
@davisjam The bug bounty program is only for security issues that affect Node.js core itself, not any third-party node modules. |
@reedloden I am referring to this high-severity REDOS issue I reported in the core |
@davisjam ah, neat. My apologies. I know the NSP had reported a bunch of ReDoS issues in third-party modules, so thought it was related to something similar. In any case, the program is not retroactive, so any already reported and fixed issues are not eligible. However, new issues that meet the minimum bar will be eligible. :-) |
Follow-up from #49
Updates necessary:
/nodejs-ecosystem
to refer researches to/nodejs
for core Node.js issuesAbove makes sense? any other?