Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference for bug bounty program for node core #169

Merged
merged 2 commits into from
Apr 11, 2018

Conversation

lirantal
Copy link
Member

@lirantal lirantal commented Mar 20, 2018

Follow-up from #49

Updates necessary:

  • Update Security WG README for clearer communication
  • Add a similar reference/link on the HackerOne platform's landing page for the /nodejs-ecosystem to refer researches to /nodejs for core Node.js issues
  • PR to the Node.js website to add similar reference as in our README

Above makes sense? any other?

@lirantal lirantal self-assigned this Mar 20, 2018
@lirantal lirantal requested review from rvagg and mhdawson March 20, 2018 20:28
README.md Outdated
@@ -52,6 +52,13 @@ security activities for Node.js core but relies on the Node.js Security Working
Group to recommend and help maintain policies and procedures for that
management.

### Node.js Bug Bounty Program

The Node.js project engages in an official bug bounty program for security researches and responsible public disclosures.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

researches -> researchers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated

The Node.js project engages in an official bug bounty program for security researches and responsible public disclosures.

The program is managed through the HackerOne platform at [https://hackerone.com/nodejs](https://hackerone.com/nodejs) with further details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ...platform. You can find more details on this page: [https...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean this?

The program is managed through the HackerOne platform.
You can find more details on this page: https://hackerone.com/nodejs

Copy link
Contributor

@drifkin drifkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits

README.md Outdated
@@ -52,6 +52,13 @@ security activities for Node.js core but relies on the Node.js Security Working
Group to recommend and help maintain policies and procedures for that
management.

### Node.js Bug Bounty Program

The Node.js project engages in an official bug bounty program for security researches and responsible public disclosures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

researches -> researchers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, @mhdawson beat me to it :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

README.md Outdated

The Node.js project engages in an official bug bounty program for security researches and responsible public disclosures.

The program is managed through the HackerOne platform at [https://hackerone.com/nodejs](https://hackerone.com/nodejs) with further details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the URL is the same as the text, how about just putting it in angle brackets like:

the HackerOne platform at <https://hackerone.com/nodejs>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other places we just use the URL so I'll change it to plain text

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion.

@lirantal
Copy link
Member Author

@mhdawson can you check my reply to your suggestion, I'm not sure I understood it.
#169 (comment)

@mhdawson
Copy link
Member

We should wait to land this until we clarify if/when core will start using Hacker one for reporting.

@reedloden
Copy link
Contributor

@lirantal should be good to land now :-)

@reedloden
Copy link
Contributor

Also submitted nodejs/nodejs.org#1627

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lirantal
Copy link
Member Author

Yes!

Awesome and thanks @reedloden for PRing to the website 👏

@lirantal lirantal merged commit b9160e0 into nodejs:master Apr 11, 2018
@davisjam
Copy link

Anyone want to send me a check for my path REDOS disclosures? ;-)

@reedloden
Copy link
Contributor

@davisjam The bug bounty program is only for security issues that affect Node.js core itself, not any third-party node modules.

@davisjam
Copy link

davisjam commented Apr 12, 2018

@reedloden I am referring to this high-severity REDOS issue I reported in the core path module on Feb 13. There's a broader description of my project here.

@reedloden
Copy link
Contributor

@davisjam ah, neat. My apologies. I know the NSP had reported a bunch of ReDoS issues in third-party modules, so thought it was related to something similar.

In any case, the program is not retroactive, so any already reported and fixed issues are not eligible. However, new issues that meet the minimum bar will be eligible. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants