Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialport is looking at conforming to streams2+ #216

Closed
chrisdickinson opened this issue May 29, 2016 · 2 comments
Closed

serialport is looking at conforming to streams2+ #216

chrisdickinson opened this issue May 29, 2016 · 2 comments

Comments

@chrisdickinson
Copy link
Contributor

@reconbot, a maintainer of node-serialport, has expressed interest in conforming more closely to the streams interface. I took a look at the serialport stream and it looked pretty close to the streams3 interface already, and commented about the differences.

Could @nodejs/streams take a look & check my assertions there?

@calvinmetcalf
Copy link
Contributor

Yup can take a look this week

On Sun, May 29, 2016, 2:07 AM Chris Dickinson notifications@github.com
wrote:

@reconbot https://github.com/reconbot, a maintainer of node-serialport,
has expressed interest in conforming more closely to the streams interface
serialport/node-serialport#832.
I took a look at the serialport stream
https://github.com/EmergingTechnologyAdvisors/node-serialport/blob/master/lib/serialport.js
and it looked pretty close to the streams3 interface already, and commented
about the differences
serialport/node-serialport#832 (comment)
.

Could @nodejs/streams https://github.com/orgs/nodejs/teams/streams take
a look & check my assertions there?


You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#216, or mute the thread
https://github.com/notifications/unsubscribe/ABE4n55SekX3DZXiQgpN11H3dgFzvafeks5qGS04gaJpZM4IpOR3
.

@mcollina
Copy link
Member

I think we can close this, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants