This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
quic: refactoring SendPendingData #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
http3-refactors
branch
from
0279419 to
96a8113
Compare
addaleax
reviewed
Jan 9, 2020
Refactoring SendPendingData for both default and http3 applications. This a step towards unifying the logic.
For DefaultApplication, use a linked list to only iterate through QuicStream instances that have data to send. Use a single unified implementation of SendPendingData for QuicApplication.
jasnell
force-pushed
the
http3-refactors
branch
from
c521620 to
867d1c3
Compare
addaleax
approved these changes
Jan 10, 2020
jasnell
added a commit
that referenced
this pull request
Jan 13, 2020
Refactoring SendPendingData for both default and http3 applications. PR-URL: #275 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed |
jasnell
added a commit
to jasnell/quic
that referenced
this pull request
Feb 3, 2020
Refactoring SendPendingData for both default and http3 applications. PR-URL: nodejs#275 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a multi-step cleanup of
QuicApplication::SendPendingData, allowing bothDefaultApplicationandHttp3Applicationto use the same baseSendPendingData()logic and making the iteration overQuicStreaminstances inDefaultApplicationmore efficient by only iterating over those that have data to send.