quic: prevent multiple cancels

PR-URL: #341 Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs · Feb 12, 2020 · 0ba4b5d · 0ba4b5d
1 parent 2781829
commit 0ba4b5d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/quic/node_quic_buffer-inl.h b/src/quic/node_quic_buffer-inl.h
@@ -81,7 +81,10 @@ size_t QuicBuffer::Consume(size_t amount) {
 }
 
 size_t QuicBuffer::Cancel(int status) {
-  return Consume(status, length());
+  if (canceled_) return 0;
+  canceled_ = true;
+  size_t t = Consume(status, length());
+  return t;
 }
 
 void QuicBuffer::Push(uv_buf_t buf, DoneCB done) {

diff --git a/src/quic/node_quic_buffer.h b/src/quic/node_quic_buffer.h
@@ -223,6 +223,7 @@ class QuicBuffer : public bob::SourceImpl<ngtcp2_vec>,
   QuicBufferChunk* head_ = nullptr;  // Current Read Position
   QuicBufferChunk* tail_ = nullptr;  // Current Write Position
 
+  bool canceled_ = false;
   bool ended_ = false;
   size_t length_ = 0;
   size_t remaining_ = 0;