-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: code fallback font #7480
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W00t! Thanks 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT ! thanks for your contribution
I had test on firefox 🟩
and on safari 🟥
so if someone have issue with that it's propably coming from is browser
Lighthouse Results
|
Description
This change uses "ui-monospace" as fallback font for IBM Plex Mono. Since Box Drawings don't appear to be aligned correctly.
This also fixes a code example which renders a file structure in ascii
Validation
before:
![image](https://private-user-images.githubusercontent.com/3940648/411180996-71d94107-8c59-45a3-b62a-8846eced7df3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDc3MTUsIm5iZiI6MTczOTM0NzQxNSwicGF0aCI6Ii8zOTQwNjQ4LzQxMTE4MDk5Ni03MWQ5NDEwNy04YzU5LTQ1YTMtYjYyYS04ODQ2ZWNlZDdkZjMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDgwMzM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDIyNjRjODQ2YTg5YWQzNmUxM2E1N2JhMDVkZWMzNmE5YzljMzg3NGVjOGYyYTI1ZTUzZDY2MzJiZTlmYWJmNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.JQDAXzCIfCI0xKgdfvC-QuI1F1VYK57Y6W6GOjOh8GY)
new:
![image](https://private-user-images.githubusercontent.com/3940648/411179864-b0ee35d6-8d17-4377-9a59-68c52bdc39c8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDc3MTUsIm5iZiI6MTczOTM0NzQxNSwicGF0aCI6Ii8zOTQwNjQ4LzQxMTE3OTg2NC1iMGVlMzVkNi04ZDE3LTQzNzctOWE1OS02OGM1MmJkYzM5YzgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDgwMzM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTcxOWM1YjdmZWM1Y2FhZDc3ZWZhZmYyYzVmOTU3NjRhODJmODljYTQ1MjA4NzgxNjcwYjBhNTRjOGQ0ZGI4MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.imhXMOsRcHrMeqnuhfe4DAIy5-AhliJUjJXsZycpyc4)
Related Issues
Fixes #7469
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.