Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: code fallback font #7480

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

arthurjdam
Copy link
Contributor

@arthurjdam arthurjdam commented Feb 8, 2025

Description

This change uses "ui-monospace" as fallback font for IBM Plex Mono. Since Box Drawings don't appear to be aligned correctly.
This also fixes a code example which renders a file structure in ascii

Validation

before:
image

new:
image

Related Issues

Fixes #7469

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@arthurjdam arthurjdam requested review from a team as code owners February 8, 2025 07:34
Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Feb 8, 2025 7:36am

Copy link
Member

@benhalverson benhalverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Southpark Nice

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W00t! Thanks 🙂

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! thanks for your contribution
I had test on firefox 🟩
and on safari 🟥

so if someone have issue with that it's propably coming from is browser

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 74 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
88.71% (739/833) 75.94% (240/316) 87.65% (142/162)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.831s ⏱️

@araujogui araujogui added this pull request to the merge queue Feb 10, 2025
Merged via the queue into nodejs:main with commit 882daf6 Feb 10, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeTabs din't render correctly "ASCII file structure"
6 participants