Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create markdown snippets linter #7431

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

araujogui
Copy link
Member

@araujogui araujogui commented Jan 27, 2025

Description

Create a script to lint code snippets syntax on learn pages.

I don't know if lint is the correct name for this but I can alter it if necessary.

Validation

turbo lint:snippets

Related Issues

Fixes #7293

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui requested review from a team as code owners January 27, 2025 15:41
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 28, 2025 11:08am

apps/site/package.json Outdated Show resolved Hide resolved
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tool !

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 84 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 96 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 88%
87.1% (750/861) 72.45% (242/334) 85.62% (143/167)

Unit Test Report

Tests Skipped Failures Errors Time
186 0 💤 0 ❌ 0 🔥 5.909s ⏱️

@araujogui araujogui added this pull request to the merge queue Jan 29, 2025
Merged via the queue into nodejs:main with commit 70f5a9f Jan 29, 2025
15 of 16 checks passed
@araujogui araujogui deleted the feat/lint-snippets branch January 29, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure all code examples are runnable
7 participants