-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump @storybook/addon-webpack5-compiler-swc from 1.0.5 to 2.0.0 #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ebpack5-compiler-swc
mikeesto
force-pushed
the
bump-storybook-swc-v2
branch
from
January 6, 2025 01:12
38c1610
to
5f73ebb
Compare
AugustinMauroy
approved these changes
Jan 6, 2025
should we close #7376 ?? |
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Jan 6, 2025
Lighthouse Results
|
bmuenzenmeyer
approved these changes
Jan 6, 2025
aymen94
approved these changes
Jan 7, 2025
reminder: this PR had not been open for the standard 48 hours prior to merge |
Oupsi I saw wrong, my bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump @storybook/addon-webpack5-compiler-swc from 1.0.5 to 2.0.0. This was a breaking change as "deep merging the user's settings with the SWC default options no longer happens".
This PR therefore updates the SWC configuration for TypeScript support.
Validation
Storybook should build and serve successfully.
Related Issues
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.