Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @storybook/addon-webpack5-compiler-swc from 1.0.5 to 2.0.0 #7388

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mikeesto
Copy link
Member

@mikeesto mikeesto commented Jan 6, 2025

Description

Bump @storybook/addon-webpack5-compiler-swc from 1.0.5 to 2.0.0. This was a breaking change as "deep merging the user's settings with the SWC default options no longer happens".

This PR therefore updates the SWC configuration for TypeScript support.

Validation

Storybook should build and serve successfully.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@mikeesto mikeesto requested a review from a team as a code owner January 6, 2025 01:06
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 6, 2025 1:13am

@bmuenzenmeyer
Copy link
Collaborator

should we close #7376 ??

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 88%
87.1% (736/845) 72.13% (233/323) 86.33% (139/161)

Unit Test Report

Tests Skipped Failures Errors Time
185 0 💤 0 ❌ 0 🔥 5.505s ⏱️

@AugustinMauroy AugustinMauroy added this pull request to the merge queue Jan 7, 2025
Merged via the queue into nodejs:main with commit 90719ac Jan 7, 2025
15 of 16 checks passed
@bmuenzenmeyer
Copy link
Collaborator

reminder: this PR had not been open for the standard 48 hours prior to merge

@AugustinMauroy
Copy link
Member

reminder: this PR had not been open for the standard 48 hours prior to merge

Oupsi I saw wrong, my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants