Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: add Upcoming CVE for EOL Versions post #7328

Merged
merged 6 commits into from
Jan 6, 2025
Merged

blog: add Upcoming CVE for EOL Versions post #7328

merged 6 commits into from
Jan 6, 2025

Conversation

RafaelGSS
Copy link
Member

Refs: nodejs/security-wg#1401

cc: @nodejs/tsc @nodejs/security-wg @nodejs/security

@RafaelGSS RafaelGSS requested a review from a team as a code owner December 12, 2024 14:17
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 6, 2025 2:25pm

@RafaelGSS RafaelGSS mentioned this pull request Dec 12, 2024
Closed
@RafaelGSS
Copy link
Member Author

Please, do not land it until the TSC team reviews that.

@richardlau
Copy link
Member

Should we mention the OpenJS Ecosystem Sustainability Program for the End-of-Life releases?
https://nodejs.org/en/about/previous-releases#commercial-support

@RafaelGSS RafaelGSS mentioned this pull request Dec 12, 2024
Open
UlisesGascon
UlisesGascon approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RafaelGSS RafaelGSS removed the blocked label Dec 20, 2024
@RafaelGSS
Copy link
Member Author

PTAL @nodejs/tsc

@RafaelGSS RafaelGSS added the github_actions:pull-request Trigger Pull Request Checks label Dec 20, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.078s ⏱️

mcollina
mcollina approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Dec 23, 2024 •
edited
Loading

@nodejs/nodejs-website If I merge this the blog post will be published or will it respect the date set in the markdown?

@ovflowd
Copy link
Member

ovflowd commented Dec 28, 2024

@nodejs/nodejs-website If I merge this the blog post will be published or will it respect the date set in the markdown?

It will be published immediately.

@RafaelGSS
Copy link
Member Author

@nodejs/tsc PTAL. I am planning to land it today so we can issue the CVEs either in the next security release or next week.

@RafaelGSS RafaelGSS added github_actions:pull-request Trigger Pull Request Checks and removed blocked labels Jan 6, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@RafaelGSS @mhdawson
Update apps/site/pages/en/blog/vulnerability/upcoming-cve-for-eol-ver…
8e5ef67 
…sions.md

Co-authored-by: Michael Dawson <mdawson@devrus.com>
Signed-off-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS force-pushed the eol-notice-blog-post branch from 1e63362 to 8e5ef67 Compare January 6, 2025 12:54
@RafaelGSS RafaelGSS added the github_actions:pull-request Trigger Pull Request Checks label Jan 6, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 6, 2025
@RafaelGSS RafaelGSS added the github_actions:pull-request Trigger Pull Request Checks label Jan 6, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 6, 2025
@RafaelGSS RafaelGSS enabled auto-merge January 6, 2025 19:02
@RafaelGSS
Copy link
Member Author

PTAL @nodejs/nodejs-website

@RafaelGSS RafaelGSS added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 5a69946 Jan 6, 2025
16 checks passed
@RafaelGSS RafaelGSS deleted the eol-notice-blog-post branch January 6, 2025 19:08
@RafaelGSS RafaelGSS mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy left review comments

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer left review comments

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@ovflowd ovflowd ovflowd approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@RafaelGSS @richardlau @AugustinMauroy @ovflowd @mcollina @bmuenzenmeyer @UlisesGascon @mhdawson @marco-ippolito