Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade next-intl to 3.24, migrate deprecated APIs #7177

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

amannn
Copy link
Contributor

@amannn amannn commented Nov 4, 2024

Description

Related to #7155, an attempt to only update next-intl in order to eliminate potential causes of errors.

Validation

npm run build locally.

Related Issues

#7155

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 9, 2024 7:02pm

@amannn amannn mentioned this pull request Nov 4, 2024
@amannn amannn marked this pull request as ready for review November 4, 2024 13:53
@amannn amannn requested a review from a team as a code owner November 4, 2024 13:53
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.5% (591/653) 76.06% (178/234) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
132 0 💤 0 ❌ 0 🔥 5.061s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Nov 11, 2024
Merged via the queue into nodejs:main with commit 344da5b Nov 11, 2024
14 checks passed
ovflowd added a commit that referenced this pull request Nov 14, 2024
bmuenzenmeyer pushed a commit that referenced this pull request Nov 21, 2024
* chore: Upgrade next-intl to 3.24, migrate deprecated APIs

* reduce changes

* revert another change

* fix: Read locale from params in layout

* address review points

---------

Co-authored-by: Claudio W <cwunder@gnome.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants