hotfix: minor changes #7127
Merged
hotfix: minor changes #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
|
Running Lighthouse audit... |
Unit Test Coverage Report
Unit Test Report
|
canerakdas
approved these changes
Oct 16, 2024
AugustinMauroy
approved these changes
Oct 16, 2024
apps/site/.eslintignore
Outdated
There was a problem hiding this comment.
#7032 established that we didn't need this file??
There was a problem hiding this comment.
I see, I was seeing ESLint trying to cover things within node_modules that's why I added it, maybe mistaken, removing it.
ESlint v9 is still too new for me 🤦
There was a problem hiding this comment.
same, and linting node_modules isn't wanted. does it work now with the ignore files removed?
Signed-off-by: Claudio W <cwunder@gnome.org>
Signed-off-by: Claudio W <cwunder@gnome.org>
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some warnings, updates packages and hot fixes minor things