Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calendar): use new CALENDAR_NODEJS_ID #7097

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Oct 7, 2024

Description

Nodejs calendar invites were accidentally deleted.
This restores access via https://nodejs.org/en/about/get-involved/events from the new calendars.

Relates to nodejs/create-node-meeting-artifacts#171

Validation

https://nodejs-org-git-fix-calendar-openjs.vercel.app/en/about/get-involved/events works and displays meetings found here

Note: Only 1 event is showing, despite 8 being present. This might be due to missing data on the invites themselves.
edit: confirmed, we events.filter(getZoomLink)

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner October 7, 2024 18:08
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 7, 2024 6:08pm

@bmuenzenmeyer bmuenzenmeyer added the fast-track Fast Tracking PRs label Oct 7, 2024
@bmuenzenmeyer
Copy link
Collaborator Author

merging this - the current site is 500ing

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.47% (589/651) 76.29% (177/232) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.778s ⏱️

@AugustinMauroy AugustinMauroy added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 10aa149 Oct 7, 2024
21 checks passed
@AugustinMauroy AugustinMauroy deleted the fix-calendar branch October 7, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants