Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated]: crowdin sync #7065

Merged
merged 95 commits into from
Oct 4, 2024
Merged

[automated]: crowdin sync #7065

merged 95 commits into from
Oct 4, 2024

Conversation

nodejs-crowdin
Copy link
Collaborator

@nodejs-crowdin nodejs-crowdin commented Oct 1, 2024

Brian: syncing numerous changes.
I also want to define a policy for when we sync.

  • weekly
  • as a milestone is hit (language 100% translated and proofread)
  • could this be automated via the GH Action

@nodejs-crowdin nodejs-crowdin requested a review from a team as a code owner October 1, 2024 13:14
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 3, 2024 1:32pm

@nodejs-crowdin nodejs-crowdin added the github_actions:pull-request Trigger Pull Request Checks label Oct 1, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AugustinMauroy
Copy link
Member

I also want to define a policy for when we sync.

We'll be able to have a cron job that checks if there's a 10% difference on a language unless it's >90%, in which case we'll automatically sync? So with that we w'ill not create pr if there are no "interesting" update/change

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to pull down the branch to fix apps/site/pages/uk/about/index.mdx - it makes me wonder if something is odd about this markdown, or the parsing, that it keeps getting these links wrong

apps/site/pages/fr/about/governance.md Outdated Show resolved Hide resolved
apps/site/pages/id/about/governance.md Outdated Show resolved Hide resolved
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer
Copy link
Collaborator

fixed some lints reported in https://github.com/nodejs/nodejs.org/pull/7081/files and other PRs- will need monitor if it keeps happening

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 6ca0f24 Oct 4, 2024
14 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the chore/crowdin branch October 4, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants