Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional information for running mjs code example #7026

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

splincool
Copy link
Contributor

Description

This PR adds additional information for the case with the mjs code example. I read the introduction section and decided to run the example with the mjs version of the code. When I saved my code as server.js and ran it with the node server.js command, I got the following error message in my terminal: To load an ES module, set "type": "module" in the package.json or use the .mjs extension. I thought that for new Node.js users who might also try to run this code and see an error in the terminal, it would be better to add this information on how to run the mjs version of the code.

Validation

add fix tests build

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@splincool splincool requested a review from a team as a code owner September 2, 2024 21:15
Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Sep 2, 2024 9:17pm

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@aymen94
Copy link
Member

aymen94 commented Sep 4, 2024

LGTM, @splincool thanks for your first contribution! 👍🎉 #newcontributor #firstcontribution

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.54% (594/656) 76.29% (177/232) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.183s ⏱️

@araujogui araujogui added this pull request to the merge queue Sep 5, 2024
Merged via the queue into nodejs:main with commit 51ddeec Sep 5, 2024
11 checks passed
joeeames pushed a commit to joeeames/nodejs.org that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants