Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: nodejs.org/learn leads to 404 #7001

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Nirmalkumar6112
Copy link
Contributor

Description

Added the redirect path to the root of the Learn nav link

Related Issues

Fixes #7000 nodejs.org/learn leads to 404

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@Nirmalkumar6112 Nirmalkumar6112 requested a review from a team as a code owner August 23, 2024 05:47
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ❌ Failed (Inspect) Aug 23, 2024 5:49am

@mAmineChniti
Copy link
Contributor

mAmineChniti commented Aug 26, 2024

@Nirmalkumar6112 maybe you should do /:locale/learn instead of /en/learn that way people get redirected to their correct locale pages and not the english one by default

@bmuenzenmeyer
Copy link
Collaborator

maybe you should do /:locale/learn instead of /en/learn

I looked at this, but it generates an error: "destination" has segments not in "source"
That seems straightforward enough, though googling for it suggests otherwise and our current code follows the as-is pattern.

for reference, we have

    {
      "source": "/guides",
      "destination": "/en/learn"
    },
    {
      "source": "/about",
      "destination": "/en/about"
    },
    {
      "source": "/community",
      "destination": "/en/get-involved"
    },

elsewhere in the same file. I'd suggest we incrementally improve the experience via this PR and then pursue future action another time - this is already 2 weeks old

@bmuenzenmeyer
Copy link
Collaborator

also - learn content is not internationalized anyway, per our decisions

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.299s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Sep 3, 2024
Merged via the queue into nodejs:main with commit 29d3af7 Sep 3, 2024
14 checks passed
joeeames pushed a commit to joeeames/nodejs.org that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodejs.org/learn leads to 404
3 participants