Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:improve-fnm-download-instructions #6946

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

Sujitale07
Copy link
Contributor

@Sujitale07 Sujitale07 commented Jul 25, 2024

fixes #6925

Description

This PR improves FNM download instructions for windows OS

Validation

I've checked this improvement by running application in my local machine

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Sujitale07 Sujitale07 requested a review from a team as a code owner July 25, 2024 13:15
Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Aug 3, 2024 3:27pm

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.188s ⏱️

Co-authored-by: Michael Esteban <mickel13@gmail.com>
Signed-off-by: Sujit Ale Magar <128675355+Sujitale07@users.noreply.github.com>
@mikeesto mikeesto added the github_actions:pull-request Trigger Pull Request Checks label Aug 4, 2024
@mikeesto mikeesto enabled auto-merge August 4, 2024 02:00
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 4, 2024
@mikeesto mikeesto added this pull request to the merge queue Aug 4, 2024
Merged via the queue into nodejs:main with commit 87fd625 Aug 4, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve fnm download instructions for Windows
2 participants