Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the default Node.js logo #6867

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Use the default Node.js logo #6867

merged 2 commits into from
Jul 1, 2024

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Jun 28, 2024

Description

Uses the default logo now that Pride month is coming to an end.
Opening now to allow for adequate review time over the weekend.

Validation

https://nodejs-org-git-default-logo-openjs.vercel.app/

Related Issues

closes #6802
closes nodejs/node#53299

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner June 28, 2024 01:59
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ❌ Failed (Inspect) Jul 1, 2024 8:17am

@nodejs nodejs locked as too heated and limited conversation to collaborators Jun 28, 2024
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Jun 28, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 28, 2024
@bmuenzenmeyer
Copy link
Collaborator Author

✅ LH Job failing because I pre-emptively locked the PR.

@nodejs nodejs unlocked this conversation Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Running Lighthouse audit...

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.268s ⏱️

@bmuenzenmeyer bmuenzenmeyer merged commit c3d2e44 into main Jul 1, 2024
13 of 15 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the default-logo branch July 1, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js Pride Flag Node.js Pride Flag
9 participants