Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: add pre security release announcement #6863

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Jun 25, 2024

@RafaelGSS RafaelGSS requested a review from a team as a code owner June 25, 2024 13:04
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ❌ Failed (Inspect) Jun 25, 2024 1:27pm

Copy link
Contributor

Running Lighthouse audit...

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.527s ⏱️

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to mention that Node.js v22.4.0 includes a security fix for fetch(), already shipped in undici v6.19.2.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd
Copy link
Member

ovflowd commented Jun 25, 2024

FYI feel free to ignore the failed Vercel check.

But can we hold off the merge of this, until we get the monorepo stuff ready?

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Jun 25, 2024

But can we hold off the merge of this, until we get the monorepo stuff ready?

How long would it take? This PR must land today.

@bmuenzenmeyer
Copy link
Collaborator

How long would it take? This PR must land today.

it's gonna be longer than that

@RafaelGSS
Copy link
Member Author

So I'm afraid that will need to merge it now. Per policy we need to inform our users 7 days before the security release

@ovflowd
Copy link
Member

ovflowd commented Jun 25, 2024

You will need to do a forced merge as a TSC member since the main branch is locked right now.

@RafaelGSS RafaelGSS merged commit 188a42a into main Jun 25, 2024
18 of 22 checks passed
@RafaelGSS RafaelGSS deleted the pre-release-7-2-24 branch June 25, 2024 15:49
@RafaelGSS
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants