Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix article layout responsiveness #6821

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

abizek
Copy link
Contributor

@abizek abizek commented Jun 6, 2024

Description

Fixes article layout responsiveness (learn page and about page)

I had to modify the tailwind config of the xs screen a little to use the built-in max-width queries(max-sm, max-md, etc). Previously xs: meant max-width of 670px, now it means min-width of 670px, correctly aligning with the built-in min-width queries. All xs: queries have been renamed max-xs: to keep the existing behavior.

xs is a bit misleading still since xs = 670px but sm = 640px and md = 768px.

Validation

2024-06-06.14-12-06.mp4

Related Issues

Fixes #6819

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: abizek <abishekilango@protonmail.com>
@abizek abizek requested a review from a team as a code owner June 6, 2024 10:21
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 6, 2024 10:24am

@abizek abizek changed the title fix(layouts): Responsiveness Fix Article layout responsiveness Jun 6, 2024
@abizek abizek changed the title Fix Article layout responsiveness Fix article layout responsiveness Jun 6, 2024
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested it on all pages and screens, and it looks great! Thanks for your effort here! 🎉

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jun 8, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 8, 2024
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 97 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Jun 8, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.211s ⏱️

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think these changes may need to be approved in Chromatic

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jun 9, 2024
Merged via the queue into nodejs:main with commit 3fb72c2 Jun 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsiveness issues between 670px and 1023px
5 participants