-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require TSC approval for stances #6772
Conversation
@nodejs/tsc , bikeshedding/different wording welcome Signed-off-by: Benjamin Gruenbaum <benjamingr@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all it's worth, I appreciate the TSC proactively handling this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Does anyone have strong opinions about how this relates to CONTENT VS CODE? I think if I had to pick, I'd see it as content. Reading those guidelines in accordance with this change, I'd resolve to say it re-enforces TSC involvement. Perhaps they should be cross-linked. |
Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Signed-off-by: Benjamin Gruenbaum <inglor@gmail.com>
cc @nodejs/tsc |
Standard governance changes within this repository require an extended period for approval. But I can't imagine the TSC or the Web Team would be against this change. To be honest, we can merge this as soon as possible. But I'm also fine waiting the 72 hours. I'd like @bmuenzenmeyer's concern addressed before we merge this, just so we can easily clarify/connect both documents, which serve as a guiding mechanism. Is the TSC OK if we update the docs of CONTENT_VS_CODE to match governance changes? |
Please do not merge this until 48h have passed or at least TSC members have had time to look when back from the weekend. |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Signed-off-by: Claudio W <cwunder@gnome.org>
I think it should likely be stressed that this is not a gatekeeping measure meant to discourage these kinds of changes but more of an awareness thing. Specifically, the TSC needs to be given the time to be aware that such changes are proposed/pending and given the time to weigh in on the possible ramifications of the change. |
@jasnell I've tried to use as neutral objective language in the text but feel free to suggest edits if you think it implies a bias against or for such initiatives. |
IMO a variant of this should be added to https://github.com/nodejs/node/blob/main/GOVERNANCE.md#technical-steering-committee and https://github.com/nodejs/TSC#list-of-tsc-responsibilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not suggesting that any changes be made to the proposed text (otherwise I would have made that explicit)... I just wanted to stress the point in the PR discussion here. |
48 hours have passed. appreciate the strong alignment on this one |
@nodejs/tsc , bikeshedding/different wording welcome
Description
Validation
Related Issues
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.