Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dont-block-the-event-loop.md #6744

Merged
merged 1 commit into from
May 30, 2024

Conversation

aitmamatovmusa
Copy link
Contributor

@aitmamatovmusa aitmamatovmusa commented May 28, 2024

Moved the text to a new line

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Moved the text to a new line

Signed-off-by: aitmamatovmusa <63698936+aitmamatovmusa@users.noreply.github.com>
@aitmamatovmusa aitmamatovmusa requested a review from a team as a code owner May 28, 2024 12:17
Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 28, 2024 0:18am

Copy link
Member

@araujogui araujogui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks for you first contribution

Copy link
Contributor

github-actions bot commented May 29, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 70 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 6.265s ⏱️

@AugustinMauroy AugustinMauroy added this pull request to the merge queue May 30, 2024
Merged via the queue into nodejs:main with commit 447d721 May 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants