Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Motion safe animations #6739

Merged
merged 2 commits into from
May 28, 2024

Conversation

canerakdas
Copy link
Member

Description

With this PR the animations we applied site-wide have been adjusted to be motion-safe for users sensitive to animations

  • Additionally, the scroll behavior of articles has been changed to smooth
  • The scroll behavior used for the body and articles has also been adjusted to be motion-safe

About reduced motion:

Validation

Screen.Recording.2024-05-26.at.16.01.54.mov

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@canerakdas canerakdas added the accessibility Issues concerning accessibility label May 26, 2024
@canerakdas canerakdas requested a review from a team as a code owner May 26, 2024 13:22
Copy link

vercel bot commented May 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 26, 2024 1:24pm

Copy link
Contributor

github-actions bot commented May 26, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 93 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 6.33s ⏱️

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this extra layer of ally work

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue May 28, 2024
Merged via the queue into nodejs:main with commit 1c4334f May 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues concerning accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants