Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Orama remote image pattern #6474

Merged
merged 1 commit into from
Mar 17, 2024
Merged

chore: Orama remote image pattern #6474

merged 1 commit into from
Mar 17, 2024

Conversation

canerakdas
Copy link
Member

Description

This PR includes fixing Orama's logo in the search box and search result pages.

Validation

The logo must load/display correctly on the search box and search result pages

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@canerakdas canerakdas added the website redesign Issue/PR part of the Node.js Website Redesign label Mar 16, 2024
@canerakdas canerakdas requested a review from a team as a code owner March 16, 2024 14:12
@vercel Vercel
Copy link

vercel bot commented Mar 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 16, 2024 2:14pm

@canerakdas canerakdas added the github_actions:pull-request Trigger Pull Request Checks label Mar 16, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 16, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 90 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 91 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 90 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟠 89 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 90 🟢 100 🟢 92 🔗

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 16, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
 80.07% (450/562) 79.55% (144/181) 71.17% (79/111)

Unit Test Report

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 4.417s ⏱️

AugustinMauroy
AugustinMauroy approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !!

@bmuenzenmeyer bmuenzenmeyer added the fast-track Fast Tracking PRs label Mar 16, 2024
@bmuenzenmeyer
Copy link
Collaborator

Fast tracking this pr

@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Mar 16, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 16, 2024
@ovflowd ovflowd added this pull request to the merge queue Mar 17, 2024
Merged via the queue into nodejs:main with commit 5853f1b Mar 17, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@ovflowd ovflowd ovflowd approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees
No one assigned
Labels
fast-track Fast Tracking PRs website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@canerakdas @bmuenzenmeyer @ovflowd @AugustinMauroy