chore: update incorrect code comments regarding dynamicParams #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
approved these changes
Mar 12, 2024
github-actions
bot
removed
the
github_actions:pull-request
ovflowd
reviewed
Mar 12, 2024
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
AugustinMauroy
approved these changes
Mar 13, 2024
aymen94
approved these changes
Mar 13, 2024
|
fast tracking - simple (but important!) change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very minor, this PR is simply updating a couple of code comments around
dynamicParamswhich I am pretty sure are wrong and just copy-pastas (and indeed they confused me at first)Check List
npx turbo formatto ensure the code follows the style guide.