Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(content): use as 100% new codebox #6437

Merged
merged 1 commit into from
Mar 8, 2024
Merged

chore(content): use as 100% new codebox #6437

merged 1 commit into from
Mar 8, 2024

Conversation

AugustinMauroy
Copy link
Member

Description

Adding possibility to switch between cjs/esm on new codeBox

Related Issues

No related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • NA I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner March 4, 2024 15:15
Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 4, 2024 3:15pm

@ovflowd
Copy link
Member

ovflowd commented Mar 4, 2024

Can you attach a screenshot of an example?

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 98 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 96 🟢 100 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.561s ⏱️

@AugustinMauroy
Copy link
Member Author

@ovflowd here you have a record. don't forget you have the preview ;)

Enregistrement.de.l.ecran.2024-03-04.a.21.39.33.mov

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mind the second tab being "ESM" instead - perhaps more recognisable?

@ovflowd
Copy link
Member

ovflowd commented Mar 6, 2024

I wouldn't mind the second tab being "ESM" instead - perhaps more recognisable?

I guess it's because on our docs we write "MJS", but I guess ESM would be more friendly for newcomers indeed

@ovflowd ovflowd added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit 6d79e91 Mar 8, 2024
15 checks passed
@ovflowd ovflowd deleted the cjs-esm branch March 8, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants