Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release blog post improvements; @author parsing and notable header #576

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

phillipj
Copy link
Member

Some improvements to the release blog post script.

  • handle @author parsing when using . instead of , in the release version header, which was the case with v5.8.0 release
  • ensure ### prefixed Notable changes header
  • bumped changelog-url version too handle new v0.10.x releases

Refs: #551 (comment)
Fixes: #553 (comment)

/cc @nodejs/release

- handle @author parsing when using . instead of , in the release version header
- ensure ### prefixed Notable changes header
- bumped changelog-url version too handle new v0.10.x releases

Refs: #551 (comment)
Fixes: #553 (comment)
@ghost
Copy link

ghost commented Mar 14, 2016

Travis build passed 👍

@mikeal
Copy link
Contributor

mikeal commented Mar 14, 2016

LGTM :)

@Fishrock123
Copy link
Contributor

see also #566

@ghost
Copy link

ghost commented Mar 14, 2016

LGTM!

@rvagg
Copy link
Member

rvagg commented Mar 14, 2016

neato, lgtm, thanks @phillipj

@phillipj
Copy link
Member Author

@Fishrock123 aaaah, I didn't catch that issue last week, just noticed it while doing a test run yesterday. This script shouldn't get in the way when you cut releases, so loosening up parsing seems okay to me.

phillipj added a commit that referenced this pull request Mar 15, 2016
Release blog post improvements; @author parsing and notable header
@phillipj phillipj merged commit 9233449 into master Mar 15, 2016
@phillipj phillipj deleted the fix/improve-release-script-parsing branch March 15, 2016 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants