Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-CN: Translation for banner #4492

Merged
merged 4 commits into from
Mar 15, 2022
Merged

zh-CN: Translation for banner #4492

merged 4 commits into from
Mar 15, 2022

Conversation

SEWeiTung
Copy link
Contributor

Ref: #4490

@SEWeiTung
Copy link
Contributor Author

@nodejs/nodejs-cn , plz have a review, thanks!

willin
willin approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

意思上正确，但有点拗口。

@SEWeiTung
Copy link
Contributor Author

SEWeiTung commented Mar 15, 2022 •
edited
Loading

@willin : 是的。按照中文的翻译并不是一个很好的方法。
我想要不改成“关于 OpenSSL 安全更新：须在 Node.js 安全补丁之后发布 ”

@willin
Copy link
Contributor

willin commented Mar 15, 2022

seems better

@SEWeiTung SEWeiTung merged commit 0b9064e into nodejs:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willin willin willin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SEWeiTung @willin