Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Node.js certification page #3190

Merged
merged 7 commits into from
Jun 20, 2020
Merged

Add a Node.js certification page #3190

merged 7 commits into from
Jun 20, 2020

Conversation

brianwarner
Copy link
Contributor

A few folks noted that there are no links to the Node.js certification programs on the site. I'm opening this PR to begin a discussion as to whether having a new menu item is a good way to raise awareness about the certifications.

The content of the page is effectively identical to that of openjsf.org/certification, with a few style and language tweaks.

This is meant to be a starting point. If there's a better way to do this, please let me know and I'd be happy to make changes.

Signed-off-by: Brian Warner brian@bdwarner.com

Signed-off-by: Brian Warner <brian@bdwarner.com>
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@nodejs/tsc , @nodejs/community-committee FYI, this adds links to the certification program which I think should be on the website.

Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MylesBorins
Copy link
Contributor

@brianwarner is there a reason to not make the link in the menu bar forward to the external cert page?

@brianwarner
Copy link
Contributor Author

@MylesBorins No particular reason, aside from maintaining consistency with the other items. If that makes more sense to folks, I can update it. It does make long term maintenance easier...

@MylesBorins
Copy link
Contributor

@brianwarner I don't have strong feelings... but was thinking that forwarding would be better from a maintenance stand point and avoid the possibility of divergence

@bnb
Copy link
Contributor

bnb commented Jun 15, 2020

It would also reduce the eventual workload on the Website Redesign - instead of having to duplicate a page, we can include a link or some kind of banner / CTA on the Learn page.

@mhdawson
Copy link
Member

@MylesBorins do you have any option to this landing and then Brian submitting a PR to update as you suggested? Just thinking it would be good to have the certification visible on the site sooner than later.

@brianwarner
Copy link
Contributor Author

I'll update my branch and push a revision later this evening so you can see how it would look.

@brianwarner
Copy link
Contributor Author

Ok folks, the separate cert page is removed, and now the menu item points to the upstream page on openjsf.org.

Also, merged in the latest changes from the current site to verify the new menu item doesn't create layout issues.

@MylesBorins
Copy link
Contributor

@brianwarner we probably want to remove the new layout if we are only including the link correct?

Also, do we want to include it on any of the INTL landing pages?

Signed-off-by: Brian Warner <brian@bdwarner.com>
@brianwarner
Copy link
Contributor Author

Good call, just pushed.

I was wondering about other languages as well, as it would be good to include it on the landing pages for languages other than English. What is the usual practice for finding the right translation?

@MylesBorins
Copy link
Contributor

@brianwarner sorry for being an it, but we likely want to remove the image from this PR as well, it isn't being used anywhere is it?

The locale folder has all the translations. you edited locale/en/index.md, you can find all the other languages in the locale/ folder

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@brianwarner
Copy link
Contributor Author

No worries, thanks for catching the image. I'll remove it now.

On the translations, I guess my question was more about finding the right translation for the word "Certification". I can try Google Translate for each of the support languages, but I'm hesitant to lean too heavily on that being accurate... thoughts?

Signed-off-by: Brian Warner <brian@bdwarner.com>
@nschonni
Copy link
Member

Translations are (theoretically) handled on Crowdin once English content is pushed. It's up to the localization teams to suggest the translations over there

@brianwarner
Copy link
Contributor Author

Thanks @nschonni, that is helpful to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.