Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: v13.11.0 release post #3014

Merged
merged 1 commit into from
Mar 12, 2020
Merged

blog: v13.11.0 release post #3014

merged 1 commit into from
Mar 12, 2020

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins merged commit f8e0b30 into nodejs:master Mar 12, 2020
@XhmikosR
Copy link
Contributor

@MylesBorins @Trott it seems deployments are broken :/

Last commit I see in https://nodejs.org/github-webhook.log is HEAD is now at df6f178... fix(docs): fix wrong translations in zh-cn

BTW perhaps we should look into switching to GitHub Actions for deploys?

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Mar 12, 2020 via email

@Trott
Copy link
Member

Trott commented Mar 12, 2020

I've pinged build about this on a couple channels.

I don't think Build WG generalists like me have the access to remove that log file. I'd be interested to know who does. Is it @nodejs/build-infra folks? I would love to have that ability.

@XhmikosR
Copy link
Contributor

Your call, but it shouldn't be too hard to switch to GitHub Actions and rsync deployments, at least in theory :)

@rvagg
Copy link
Member

rvagg commented Mar 13, 2020

@XhmikosR want to draft up a GitHub Action for this? If I can encrypt and store a secret that has an SSH key then we could isolate it to a single user account on the server and push content up directly. It'll need to be two step - 1) rsync content and 2) run an ssh command on the server to queue an invalidation of our cloudflare cached content. As long as we have strong assurance of the secret content not getting leaked then it could be a good way of pulling back control of this process into this repo rather than relying so much on build-infra to support when things go wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants