Revert "feat: minify HTML on build (#2537)" #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0cc3648. Refs: nodejs#2537
|
And to be clear, I am fine with closing this and leaving the commit as it is if that is what people want, but I believe that the original PR was landed prematurely. |
|
I agree, this should be reverted. Now, I understand if we don't want to do this via Cloudflare, but the slowdown from this isn't justified by the gains IMHO. |
MylesBorins
approved these changes
Nov 27, 2019
XhmikosR
approved these changes
Nov 27, 2019
|
SGTM. +1 to turning it on through CloudFlare, since that’s where the majority of our traffic is served from anyway AFAIK. |
aymen94
approved these changes
Nov 27, 2019
|
if there is a better alternative, then so be it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0cc3648. Based on my estimations and calculations, the benefit is minimal, while making our build pipeline more complex, more time consuming, adding a dependency and making the output less readable. Contrary to assumptions in the original PR, the patch does not affect the docs.
(Also, @XhmikosR suggested that there might be a better alternative provided by Cloudflare.)
Refs: #2537
cc @nschonni @MylesBorins @aymen94 @bnb @Trott