Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handlebars to version 4.0.3 🚀 #259

Merged
merged 2 commits into from
Oct 23, 2015

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello 👋

🚀🚀🚀

handlebars just published its new version 4.0.3, which is not covered by your current version range.

If this pull request passes your tests you can publish your software with the latest version of handlebars – otherwise use this branch to work on adaptions and fixes.

Happy fixing and merging 🌴


The new version differs by 118 commits .

  • 9365b82 v4.0.3
  • bf09177 Update release notes
  • 94c840b Create data frame for @partial-block
  • 861d6f7 Fix tests under IE
  • fffb5a9 Fix iteration over undefined values
  • 0878179 Allow for escaped ] characters in [] IDs
  • 641fe33 Update travis to test node 0.12 and 4.0.0
  • 733b7c8 Merge pull request #1091 from nikolas/patch-2
  • 9a86e40 Merge pull request #1090 from nikolas/patch-1
  • efad390 fix typo in release notes
  • 3696d23 grammar fixes in 4.0.0 release notes
  • a5a3ab0 v4.0.2
  • c833541 Update release notes
  • 7b1fdf8 Fix use of decorators within partials
  • c7b28a6 v4.0.1

There are 118 commits in total. See the full diff.


This pull request was created by greenkeeper.io.
It keeps your software, up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡

@fhemberger
Copy link
Contributor

This update has to be tested, handling of contexts changed between Handlebars v3 and v4 (this could break some stuff).

@stevemao
Copy link
Contributor

I believe the test coverage might not be enough. Handlebars v3 and v4 are quite different.

@fhemberger
Copy link
Contributor

@stevemao We only test (parts) of our scripts at the moment, we don't have any integration/visual regression tests at all. That's why I wrote the comment.

@stevemao
Copy link
Contributor

I can see that. I think it is a bit hard to merge this. The time we spend on testing this manually might be the same as adding the tests.

@fhemberger
Copy link
Contributor

@nodejs/website To make sure the handlebars update doesn't break anything, I did a full build with v3.0.3 and diffed it to a build with 4.0.3 – luckily there were only three tiny changes necessary, so everything should be fine.

@fhemberger fhemberger mentioned this pull request Oct 23, 2015
@fhemberger
Copy link
Contributor

Ignore the failing test on Travis, standard is doing weird things again.

@phillipj
Copy link
Member

Nicely tested @fhemberger 👍

fhemberger added a commit that referenced this pull request Oct 23, 2015
Update handlebars to version 4.0.3 🚀
@fhemberger fhemberger merged commit 6a0ae78 into master Oct 23, 2015
@fhemberger fhemberger deleted the greenkeeper-handlebars-4.0.3 branch October 23, 2015 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants