Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Russian locale: remove untranslated files. #2527

Merged
merged 1 commit into from
Sep 8, 2019
Merged

Russian locale: remove untranslated files. #2527

merged 1 commit into from
Sep 8, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 7, 2019

No description provided.

SEWeiTung
SEWeiTung approved these changes Sep 7, 2019
View reviewed changes
Copy link
Contributor

@SEWeiTung SEWeiTung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no-one translating these files, no need to be kept here.

@Trott
Copy link
Member

Trott commented Sep 7, 2019

@nodejs/nodejs-ru

@Trott
Copy link
Member

Trott commented Sep 7, 2019

(I agree these can be removed if there is no translation going on. The ping was in case anyone wanted to translate one or more of these--in case they didn't realize there was lots of untranslated content.)

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 7, 2019

I'm just trying to clean up the locales. When a page has been translated, then it should be added, not before.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 7, 2019

I see one ongoing translation in #2473. I can exclude the removal of this file assuming that PR will land.

@XhmikosR XhmikosR mentioned this pull request Sep 8, 2019
Merged
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 8, 2019

So, how should we proceed with this?

@SEWeiTung
Copy link
Contributor

Until #2473 is merged

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 8, 2019

I don't follow? I can just skip this file from this PR, if #2473 is going to be merged.

Note that this removes obsolete/old files too.

@SEWeiTung
Copy link
Contributor

SEWeiTung commented Sep 8, 2019 •
edited
Loading

@XhmikosR , What I mean is you can revert ONLY this file 'locale/ru/docs/guides/simple-profiling.md' but just remove the others. But I still see your file is in the state of remove.
image

@SEWeiTung SEWeiTung merged commit dbffe19 into nodejs:master Sep 8, 2019
@XhmikosR XhmikosR deleted the master-xmr-rm-ru-english branch September 8, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SEWeiTung SEWeiTung SEWeiTung approved these changes

@alexandrtovmach alexandrtovmach Awaiting requested review from alexandrtovmach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XhmikosR @Trott @SEWeiTung