Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update built-in debugger link to latest #1913

Merged
merged 2 commits into from
Dec 19, 2018
Merged

Update built-in debugger link to latest #1913

merged 2 commits into from
Dec 19, 2018

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Nov 26, 2018

Update built-in debugger link to the latest in guides/debugging-getting-started.

@refack refack added the content Issues/pr concerning content label Nov 26, 2018
@ZYSzys
Copy link
Member Author

ZYSzys commented Nov 27, 2018

Find that it's indeed the Legacy Debugger section, I'm kind of confused now whether we should change this.

Copy link
Contributor

@fhemberger fhemberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZYSzys Please revert the changes, as it's indeed the legacy debugger.

I only noticed, that in the Korean version, links to the "Built-in Debugger" point to

So these links should be replaced with https://nodejs.org/dist/latest-v6.x/docs/api/debugger.html, as in the other languages.

If I'm not mistaken, this should be the only remaining change.

@ZYSzys
Copy link
Member Author

ZYSzys commented Dec 19, 2018

@fhemberger 👌Reverted and updated the link of "Built-in Debugger" in the Korean version.

@fhemberger fhemberger merged commit d001e32 into master Dec 19, 2018
@fhemberger fhemberger deleted the latest-debugger branch December 19, 2018 10:58
@fhemberger
Copy link
Contributor

@ZYSzys Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues/pr concerning content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants