Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Persian translation #1871

Closed
wants to merge 10 commits into from
Closed

Conversation

armanatory
Copy link

minor fixes in persian translation

Copy link
Contributor

@fhemberger fhemberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't submit:

  • Editor config files (VS Code)
  • Blog posts (locale/fa/blog), those remain untranslated.

Copy link
Contributor

@fhemberger fhemberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all files locale/.vs/ from the PR.

@@ -24,7 +24,10 @@ This documentation describes the built-in modules provided by Node.js. It does n

<ul>
<li><a href="https://nodejs.org/docs/latest-v9.x/api/">Node.js 9.x</a></li>
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these git merge artifacts.

@@ -1,9 +1,14 @@
{
"title": "Node.js",
"author": "Node.js Foundation",
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these git merge artifacts.

@@ -0,0 +1,6 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all files in locale/.vs/ from the PR.

@@ -0,0 +1,4 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove locale/fa/blog/index.md.

@@ -0,0 +1,54 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove locale/fa/blog/nodejs-road-ahead.md.

@@ -1,9 +1,14 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the "blog" key here, it won't show up in the local navigation.

"blog": {

@fhemberger
Copy link
Contributor

Closed in favor of #1866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants