Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing code-and-learn with upcoming events #1825

Merged
merged 1 commit into from Sep 29, 2018
Merged

Add missing code-and-learn with upcoming events #1825

merged 1 commit into from Sep 29, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2018

Ref: #1824.

@ghost ghost requested review from osk2 and a user September 29, 2018 01:47
osk2
osk2 approved these changes Sep 29, 2018
View reviewed changes
Copy link
Contributor

@osk2 osk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhemberger fhemberger merged commit fec815e into nodejs:master Sep 29, 2018
@ghost
Copy link
Author

ghost commented Sep 29, 2018

Thanks all!

@snyk-bot snyk-bot mentioned this pull request Mar 12, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Dec 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osk2 @fhemberger