Update tls client test #9968
Update tls client test #9968
Conversation
imyller
added
the
code-and-learn
|
The commit message should start with |
There was a problem hiding this comment.
- Merge commits as single commit
- Commit message is too long, follow commit message guideline
rgoodwin
force-pushed
the
update-tls-client-test
branch
from
4e6c8c5
to
9b9161c
Compare
|
@mscdex @princejwesley cleaned up commit message and squashed commits. Please let me know if there is anything else. |
|
The prefix should be |
Replace variable defs using var with more up to date const/let. Updated tests to use strict equality to ensure type and value comparision tests: wrap callback functions in common.mustCall to ensure single execution
rgoodwin
force-pushed
the
update-tls-client-test
branch
from
9b9161c
to
d1e235a
Compare
|
@rgoodwin gj, commit message updated. |
|
@mscdex Fixed, thanks for catching that. |
|
@addaleax Can you recommend what I should do now. I'm new to this build and it looks like it has a lot of target OS/hardware combos. It looks like it failed on ARM etc... because of a timeout. Not sure how I would debug on those platforms. I'm on OSX and on that I followed the contribution guide and ran Or are the timeouts part of long test cycles and I somehow need to re-run the build etc..? Thanks |
|
@rgoodwin These timeouts are not related to the test file you are changing, so we should be good here :) |
* Replace variable defs using var with more up to date const/let. * Updated tests to use strict equality to ensure type and value comparision * wrap callback functions in common.mustCall to ensure single execution PR-URL: #9968 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in c142e27. Thank you for the PR and for participating in the code-and-learn! |
* Replace variable defs using var with more up to date const/let. * Updated tests to use strict equality to ensure type and value comparision * wrap callback functions in common.mustCall to ensure single execution PR-URL: #9968 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
* Replace variable defs using var with more up to date const/let. * Updated tests to use strict equality to ensure type and value comparision * wrap callback functions in common.mustCall to ensure single execution PR-URL: nodejs#9968 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
* Replace variable defs using var with more up to date const/let. * Updated tests to use strict equality to ensure type and value comparision * wrap callback functions in common.mustCall to ensure single execution PR-URL: nodejs#9968 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
* Replace variable defs using var with more up to date const/let. * Updated tests to use strict equality to ensure type and value comparision * wrap callback functions in common.mustCall to ensure single execution PR-URL: #9968 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tests
Description of change
Update tls test with
const/letfor definition of variables (instead of using var).common.mustCallto avoid repeated calls