Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Using const instead of var. #9926

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/parallel/test-console-instance.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ process.stdout.write = process.stderr.write = function() {
};

// make sure that the "Console" function exists
assert.equal('function', typeof Console);
assert.strictEqual('function', typeof Console);

// make sure that the Console constructor throws
// when not given a writable stream instance
Expand All @@ -35,7 +35,7 @@ out.write = err.write = function(d) {};
var c = new Console(out, err);

out.write = err.write = function(d) {
assert.equal(d, 'test\n');
assert.strictEqual(d, 'test\n');
called = true;
};

Expand All @@ -48,7 +48,7 @@ c.error('test');
assert(called);

out.write = function(d) {
assert.equal('{ foo: 1 }\n', d);
assert.strictEqual('{ foo: 1 }\n', d);
called = true;
};

Expand All @@ -60,10 +60,10 @@ assert(called);
called = 0;
out.write = function(d) {
called++;
assert.equal(d, called + ' ' + (called - 1) + ' [ 1, 2, 3 ]\n');
assert.strictEqual(d, called + ' ' + (called - 1) + ' [ 1, 2, 3 ]\n');
};
[1, 2, 3].forEach(c.log);
assert.equal(3, called);
assert.strictEqual(3, called);

// Console() detects if it is called without `new` keyword
assert.doesNotThrow(function() {
Expand Down
18 changes: 9 additions & 9 deletions test/parallel/test-dgram-msgsize.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var dgram = require('dgram');
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');

// Send a too big datagram. The destination doesn't matter because it's
// not supposed to get sent out anyway.
var buf = Buffer.allocUnsafe(256 * 1024);
var sock = dgram.createSocket('udp4');
const buf = Buffer.allocUnsafe(256 * 1024);
const sock = dgram.createSocket('udp4');
sock.send(buf, 0, buf.length, 12345, '127.0.0.1', common.mustCall(cb));
function cb(err) {
assert(err instanceof Error);
assert.equal(err.code, 'EMSGSIZE');
assert.equal(err.address, '127.0.0.1');
assert.equal(err.port, 12345);
assert.equal(err.message, 'send EMSGSIZE 127.0.0.1:12345');
assert.strictEqual(err.code, 'EMSGSIZE');
assert.strictEqual(err.address, '127.0.0.1');
assert.strictEqual(err.port, 12345);
assert.strictEqual(err.message, 'send EMSGSIZE 127.0.0.1:12345');
sock.close();
}