Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use strictEqual instead of equal in test-domain #9890

Closed
wants to merge 1 commit into from

Conversation

jreading
Copy link

@jreading jreading commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the domain Issues and PRs related to the domain subsystem. label Dec 1, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016

The commit message needs to have the appropriate subsystem prefix, in this case it's test: .

@jreading jreading changed the title use strictEqual instead of equal in test-domain test: use strictEqual instead of equal in test-domain Dec 1, 2016
@jreading
Copy link
Author

jreading commented Dec 1, 2016

@mscdex Fixed. Thanks!

@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 1, 2016

@jasnell
Copy link
Member

jasnell commented Dec 4, 2016

CI was a bit too flaky. Running again: https://ci.nodejs.org/job/node-test-pull-request/5182/

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green. thank you for the PR and for participating in the code-and-learn!

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2016
Use assert.strictEqual() instead of assert.equal().

PR-URL: nodejs#9890
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 5, 2016

Landed in c8da009.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
Use assert.strictEqual() instead of assert.equal().

PR-URL: #9890
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Use assert.strictEqual() instead of assert.equal().

PR-URL: nodejs#9890
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Use assert.strictEqual() instead of assert.equal().

PR-URL: nodejs#9890
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Use assert.strictEqual() instead of assert.equal().

PR-URL: #9890
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Use assert.strictEqual() instead of assert.equal().

PR-URL: #9890
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Use assert.strictEqual() instead of assert.equal().

PR-URL: #9890
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants