Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve description of module exports #9622

Merged
merged 1 commit into from
Nov 29, 2016

Commits on Nov 29, 2016

  1. doc: improve description of module exports

    - Do not use word alias, it isn't well defined
    - Fix return value of require() example, which confusingly was not the
      exported API as it should have been.
    - Fix the require() example, which claimed that the module exported `0`,
      when it exports `some_func`.
    - Describe best practice in keeping exports and module.exports bound
      together.
    - Describe why exports exists
    - Remove reference to magic, which is also not well defined
    
    PR-URL: nodejs#9622
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sam-github committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    5887c2b View commit details
    Browse the repository at this point in the history