Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move TSC and CTC meeting minutes out of core repo #9503

Closed
wants to merge 1 commit into from
Closed

doc: move TSC and CTC meeting minutes out of core repo #9503

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 7, 2016

Checklist
  • documentation is changed or added
Affected core subsystem(s)

doc

Description of change

The TSC and CTC meeting minutes are more properly placed in the nodejs/tsc and nodejs/ctc repositories, respectively.

See: nodejs/CTC#27 and nodejs/TSC#164

@jasnell
doc: move TSC and CTC meeting minutes out of core repo
787488b 
The TSC and CTC meeting minutes are more properly placed in
the nodejs/tsc and nodejs/ctc repositories, respectively.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 7, 2016
cjihrig
cjihrig approved these changes Nov 7, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM once the PRs to the other repos land.

@MylesBorins
Copy link
Contributor

looks at all those deleted lines!

LGTM when it has landed in the other repo

mhdawson
mhdawson approved these changes Nov 7, 2016
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once PRs in other repos land

evanlucas
evanlucas approved these changes Nov 7, 2016
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM once the other two PRs land

Trott
Trott approved these changes Nov 8, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

lpinca
lpinca approved these changes Nov 8, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pile-on LGTM.

jasnell added a commit that referenced this pull request Nov 18, 2016
@jasnell
doc: move TSC and CTC meeting minutes out of core repo
976fe25 
The TSC and CTC meeting minutes are more properly placed in
the nodejs/tsc and nodejs/ctc repositories, respectively.

PR-URL: #9503
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@jasnell
Copy link
Member Author

jasnell commented Nov 18, 2016

Landed in 976fe25

@jasnell jasnell closed this Nov 18, 2016
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@jasnell @addaleax
doc: move TSC and CTC meeting minutes out of core repo
4ddc238 
The TSC and CTC meeting minutes are more properly placed in
the nodejs/tsc and nodejs/ctc repositories, respectively.

PR-URL: #9503
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@jasnell @MylesBorins
doc: move TSC and CTC meeting minutes out of core repo
8475ba2 
The TSC and CTC meeting minutes are more properly placed in
the nodejs/tsc and nodejs/ctc repositories, respectively.

PR-URL: #9503
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@jasnell @MylesBorins
doc: move TSC and CTC meeting minutes out of core repo
34405dd 
The TSC and CTC meeting minutes are more properly placed in
the nodejs/tsc and nodejs/ctc repositories, respectively.

PR-URL: #9503
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@jasnell @MylesBorins
doc: move TSC and CTC meeting minutes out of core repo
7a94e1c 
The TSC and CTC meeting minutes are more properly placed in
the nodejs/tsc and nodejs/ctc repositories, respectively.

PR-URL: #9503
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@jasnell @MylesBorins
doc: move TSC and CTC meeting minutes out of core repo
4da8a50 
The TSC and CTC meeting minutes are more properly placed in
the nodejs/tsc and nodejs/ctc repositories, respectively.

PR-URL: #9503
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@evanlucas evanlucas evanlucas approved these changes

@Trott Trott Trott approved these changes

@williamkapke williamkapke williamkapke approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jasnell @MylesBorins @silverwind @evanlucas @Trott @williamkapke @lpinca @cjihrig @mhdawson @nodejs-github-bot