Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name repl anonymous functions #9356

Closed
wants to merge 2 commits into from
Closed

name repl anonymous functions #9356

wants to merge 2 commits into from

Conversation

pvsousalima
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

repl

Description of change

repl: name anonymous functions in repl module

name anonymous functions in repl module
the changes are related to Ref: #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable

@pvsousalima
repl: name anonymous functions in repl module
ffcb038 
name anonymous functions in repl module
the changes are related to Ref: #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable
@pvsousalima
repl: name anonymous functions in repl module
54dee96 
removing long function names to match the 80
character limitation
@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Oct 29, 2016
@pvsousalima pvsousalima changed the title Name repl anonymous name repl anonymous Oct 29, 2016
@pvsousalima pvsousalima changed the title name repl anonymous name repl anonymous functions Oct 29, 2016
@Trott
Copy link
Member

Trott commented Oct 29, 2016

LGTM if CI is ✅

jasnell
jasnell approved these changes Oct 30, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silverwind
Copy link
Contributor

Thanks! Landed in e658f5b.

@silverwind silverwind closed this Nov 1, 2016
silverwind pushed a commit that referenced this pull request Nov 1, 2016
@pvsousalima @silverwind
repl: name anonymous functions
e658f5b 
the changes are related to #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable

PR-URL: #9356
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@pvsousalima @evanlucas
repl: name anonymous functions
071836a 
the changes are related to #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable

PR-URL: #9356
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
Merged
@MylesBorins MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 8, 2017
@MylesBorins MylesBorins added dont-land-on-v6.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pvsousalima @Trott @silverwind @jasnell @MylesBorins @nodejs-github-bot