Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: significantly improve the performance of the url module #933

Closed
wants to merge 34 commits into from

Commits on Apr 17, 2015

  1. Working on v2.0.0

    chrisdickinson committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    e61ee49 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2015

  1. doc: update CONTRIBUTING.md

    This commit:
      - fixes development branch (v1.x -> master)
      - updates stability index wording
      - use iojs binary instead of node
    
    PR-URL: nodejs#1466
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    brendanashworth committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    6870764 View commit details
    Browse the repository at this point in the history
  2. Revert "http: don't bother making a copy of the options"

    This reverts commit 06cfff9.
    
    Reverted because it introduced a regression where (because options were
    modified in the later functionality) options.host and options.port would
    be overridden with values provided in other, supported ways.
    
    PR-URL: nodejs#1467
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    brendanashworth committed Apr 18, 2015
    5 Configuration menu
    Copy the full SHA
    7180597 View commit details
    Browse the repository at this point in the history
  3. test: add test for 06cfff9 regression

    This commit adds a test to ensure all options are NOT modified after
    passing them to http.request. Specifically options.host and options.port
    are the most prominent that would previously error, but add the other
    options that have default values.
    
    options.host and options.port were overridden for the one-argument
    net.createConnection(options) call.
    
    PR-URL: nodejs#1467
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    brendanashworth committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    6bf85bc View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2015

  1. Merge v1.8.1.

    This brings in the '%PYTHON%' revert, and restores
    the correct NODE_MODULE_VERSION.
    
    PR-URL: nodejs#1482
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    chrisdickinson committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    59a5c98 View commit details
    Browse the repository at this point in the history
  2. doc: update AUTHORS list

    Update AUTHORS list using tools/update-authors.sh
    
    PR-URL: nodejs#1476
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    rvagg committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    2632775 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2015

  1. doc: add spaces to child.kill example

    PR-URL: nodejs#1503
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    enaqx authored and brendanashworth committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    b16a328 View commit details
    Browse the repository at this point in the history
  2. doc: add Fishrock123 to the TC

    as per nodejs#1502
    
    PR-URL: nodejs#1507
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Fishrock123 committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    22aafa5 View commit details
    Browse the repository at this point in the history
  3. tls_wrap: use localhost if options.host is empty

    tls.connect(options) with no options.host should accept a certificate
    with CN: 'localhost'. Fix Error: Hostname/IP doesn't match
    certificate's altnames: "Host: undefined. is not cert's CN: localhost"
    
    'localhost' is not added directly to defaults because that is not
    always desired (for example, when using options.socket)
    
    PR-URL: nodejs#1493
    Fixes: nodejs#1489
    Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    sitegui authored and silverwind committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    a7d7463 View commit details
    Browse the repository at this point in the history
  4. module: remove '' from Module.globalPaths

    If `$NODE_PATH` contains trailing separators, `Module.globalPaths` will
    contains empty strings. When `Module` try to resolve a module's path,
    `path.resolve('', 'index.js')` will boil down to `$PWD/index.js`, which
    makes sub modules can access global modules and get unexpected result.
    
    PR-URL: nodejs#1488
    Reviewed-By: Roman Reiss <me@silverwind.io>
    chrisyip authored and silverwind committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    7384ca8 View commit details
    Browse the repository at this point in the history
  5. doc: update branch to master

    Update the remaining markdown files to refer to the master branch.
    PR-URL: nodejs#1511
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    silverwind committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    bb254b5 View commit details
    Browse the repository at this point in the history
  6. buffer: little improve for Buffer.concat method

    When buffer list less than 2, no need to calculate the length.
    The change's benchmark result is here:
    https://gist.github.com/JacksonTian/2c9e2bdec00018e010e6
    It improve 15% ~ 25% speed when list only have one buffer,
    to other cases no effect.
    
    PR-URL: nodejs#1437
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
    JacksonTian authored and brendanashworth committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    3d3083b View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2015

  1. net: cleanup connect logic

    Separates out the lookup logic for net.Socket. In the event
    the `host` property is an IP address, the lookup is skipped.
    
    PR-URL: nodejs#1505
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
    evanlucas committed Apr 24, 2015
    Configuration menu
    Copy the full SHA
    1bef717 View commit details
    Browse the repository at this point in the history
  2. net: add lookup option to Socket.prototype.connect

    Allows customization of the lookup function used when
    Socket.prototype.connect is called using a hostname.
    
    PR-URL: nodejs#1505
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
    evanlucas committed Apr 24, 2015
    Configuration menu
    Copy the full SHA
    4abe2fa View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2015

  1. doc: add TC meeting 2015-04-08 minutes

    PR-URL: nodejs#1497
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    rvagg authored and julianduque committed Apr 25, 2015
    Configuration menu
    Copy the full SHA
    f3cc50f View commit details
    Browse the repository at this point in the history
  2. doc: Add Addon API (NAN) to working group list

    Also update nan and examples repositories links to io.js organization
    
    PR-URL: nodejs#1523
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    julianduque committed Apr 25, 2015
    Configuration menu
    Copy the full SHA
    5178f93 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2015

  1. util: add Map and Set inspection support

    PR-URL: nodejs#1471
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    monsanto authored and chrisdickinson committed Apr 26, 2015
    Configuration menu
    Copy the full SHA
    bf7ac08 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2015

  1. win,node-gyp: enable delay-load hook by default

    The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
    for more background.
    
    PR-URL: nodejs#1433
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    piscisaureus committed Apr 27, 2015
    Configuration menu
    Copy the full SHA
    3bda6cb View commit details
    Browse the repository at this point in the history
  2. test: adjust Makefile/test-ci, add to vcbuild.bat

    PR-URL: nodejs#1530
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    rvagg committed Apr 27, 2015
    1 Configuration menu
    Copy the full SHA
    5472139 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2015

  1. test: fix test-net-dns-custom-lookup test assertion

    The assertion made an assumption that the IPv6 address would always be
    `::1`. Since the address can be different on different platforms, it
    has been changed to allow multiple addresses.
    
    Fixes: nodejs#1527
    PR-URL: nodejs#1531
    Reviewed-By: Rod Vagg <rod@vagg.org>
    evanlucas committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    bfae823 View commit details
    Browse the repository at this point in the history
  2. build: remove -J from test-ci

    parallel tests still not working on most build slaves
    
    PR-URL: nodejs#1544
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    rvagg committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    2a3c8c1 View commit details
    Browse the repository at this point in the history
  3. doc: fix util.deprecate example

    PR-URL: nodejs#1535
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Julian Duque <julianduquej@gmail.com>
    enaqx authored and Fishrock123 committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    e55fdc4 View commit details
    Browse the repository at this point in the history
  4. string_decoder: don't cache Buffer.isEncoding

    Some modules are monkey-patching Buffer.isEncoding, so without this
    they cannot do that.
    
    Fixes: nodejs#1547
    PR-URL: nodejs#1548
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    mscdex committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    0fa6c4a View commit details
    Browse the repository at this point in the history
  5. doc: Add Known issues to v1.7.0/1.7.1 CHANGELOG

    PR-URL: nodejs#1473
    Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
    yosuke-furukawa committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    391cae3 View commit details
    Browse the repository at this point in the history
  6. doc: add TC meeting 2015-04-15 minutes

    PR-URL: nodejs#1498
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    rvagg authored and julianduque committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    1bcdf46 View commit details
    Browse the repository at this point in the history
  7. os: remove trailing slash from os.tmpdir()

    This commit makes `os.tmpdir()` behave consistently on all platforms. It
    changes `os.tmpdir()` to always return a path without trailing slash.
    
    Semver: major
    Fixes: nodejs#715
    PR-URL: nodejs#747
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    tellnes authored and chrisdickinson committed Apr 28, 2015
    1 Configuration menu
    Copy the full SHA
    b57cc51 View commit details
    Browse the repository at this point in the history
  8. deps: upgrade v8 to 4.2.77.13

    This commit applies some secondary changes in order to make `make test`
    pass cleanly:
    
    * disable broken postmortem debugging in common.gypi
    
    * drop obsolete strict mode test in parallel/test-repl
    
    * drop obsolete test parallel/test-v8-features
    
    PR-URL: nodejs#1232
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    bnoordhuis authored and chrisdickinson committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    36cd5fb View commit details
    Browse the repository at this point in the history
  9. deps: enable v8 postmortem debugging again

    Cherry-pick https://codereview.chromium.org/1033733003 from upstream
    and re-enable postmortem debugging.
    
    PR-URL: nodejs#1232
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    bnoordhuis authored and chrisdickinson committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    db4ded5 View commit details
    Browse the repository at this point in the history
  10. deps: upgrade v8 to 4.2.77.15

    This includes the out-of-tree patch (but fixed in upstream HEAD) from
    commit 41c00a2 ("deps: enable v8 postmortem debugging again".)
    
    PR-URL: nodejs#1399
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    bnoordhuis authored and chrisdickinson committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    01e6632 View commit details
    Browse the repository at this point in the history
  11. deps: upgrade v8 to 4.2.77.18

    This commit applies a secondary change in order to make `make test`
    pass cleanly, specifically re-disabling post-mortem debugging in
    common.gypi.
    
    PR-URL: nodejs#1506
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    chrisdickinson committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    01652c7 View commit details
    Browse the repository at this point in the history
  12. deps: enable v8 postmortem debugging again

    Cherry-pick https://codereview.chromium.org/1033733003 from upstream
    and re-enable postmortem debugging.
    
    PR-URL: nodejs#1232
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    bnoordhuis authored and chrisdickinson committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    509b59e View commit details
    Browse the repository at this point in the history
  13. fs: validate fd on fs.write

    PR-URL: nodejs#1553
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    julianduque committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    f9c681c View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2015

  1. test: extend timeouts for ARMv6

    Based on tests running on original Raspberry Pi
    
    PR-URL: nodejs#1554
    Reviewed-By: Roman Reiss <me@silverwind.io>
    rvagg committed Apr 29, 2015
    Configuration menu
    Copy the full SHA
    f9b226c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf07d13 View commit details
    Browse the repository at this point in the history