Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated links #9278

Closed
wants to merge 4 commits into from
Closed

Fix outdated links #9278

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3841a28
Fix outdated links
lovexi Oct 25, 2016
a7e1bde
Fix the link format
lovexi Oct 25, 2016
770d972
Refactor
lovexi Oct 25, 2016
347ad3a
Move valid link to the bottom
lovexi Oct 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/guides/building-node-with-ninja.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Building Node with Ninja

The purpose of this guide is to show how to build Node.js using [Ninja][], as doing so can be significantly quicker than using `make`. Please see [Ninja's site][Ninja] for installation instructions (unix only).
The purpose of this guide is to show how to build Node.js using [Ninja](https://github.com/ninja-build/ninja), as doing so can be significantly quicker than using `make`. Please see [Ninja's site](https://ninja-build.org/) for installation instructions (unix only).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the URLs to the bottom where the current Ninja link is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed! Modified the link at the bottom.


To build Node with ninja, there are 3 steps that must be taken:

Expand Down