Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform specific teams to onboarding-extras #9009

Closed
wants to merge 4 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/onboarding-extras.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
| upgrading c-ares | @jbergstroem |
| upgrading http-parser | @jbergstroem, @nodejs/http |
| upgrading libuv | @saghul |
| platform specific | @nodejs/platform-{aix,arm,freebsd,macos,ppc,smartos,s390,windows} |


When things need extra attention, are controversial, or `semver-major`: @nodejs/ctc
Expand Down Expand Up @@ -76,10 +77,10 @@ Please use these when possible / appropriate
### Other Labels

* Operating system labels
* `os x`, `windows`, `solaris`
* `macos`, `windows`, `smartos`, `aix`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside: this has not yet been changed

* No linux, linux is the implied default
* Architecture labels
* `arm`, `mips`
* `arm`, `mips`, `s390`, `ppc`
* No x86{_64}, since that is the implied default
* `lts-agenda`, `lts-watch-v*`
* tag things that should be discussed to go into LTS or should go into a specific LTS branch
Expand Down