Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-net-server-max-connections #8931

Closed
wants to merge 2 commits into from
Closed

test: refactor test-net-server-max-connections #8931

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ffb714
test: refactor test-net-server-max-connections
Trott Oct 4, 2016
d467bbc
squash: nits
Trott Oct 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 20 additions & 24 deletions test/parallel/test-net-server-max-connections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,31 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

var net = require('net');
const net = require('net');

// This test creates 200 connections to a server and sets the server's
// maxConnections property to 100. The first 100 connections make it through
// and the last 100 connections are rejected.
// This test creates 20 connections to a server and sets the server's
// maxConnections property to 10. The first 10 connections make it through
// and the last 10 connections are rejected.

var N = 200;
var count = 0;
const N = 20;
var closes = 0;
var waits = [];
const waits = [];

var server = net.createServer(function(connection) {
console.error('connect %d', count++);
const server = net.createServer(common.mustCall(function(connection) {
connection.write('hello');
waits.push(function() { connection.end(); });
});
}, N / 2));

server.listen(0, function() {
makeConnection(0);
});

server.maxConnections = N / 2;

console.error('server.maxConnections = %d', server.maxConnections);


function makeConnection(index) {
var c = net.createConnection(server.address().port);
const c = net.createConnection(server.address().port);
var gotData = false;

c.on('connect', function() {
Expand All @@ -42,10 +38,10 @@ function makeConnection(index) {
closes++;

if (closes < N / 2) {
assert.ok(server.maxConnections <= index,
index +
' was one of the first closed connections ' +
'but shouldnt have been');
assert.ok(
server.maxConnections <= index,
`${index} should not have been one of the first closed connections`
);
}

if (closes === N / 2) {
Expand All @@ -58,11 +54,11 @@ function makeConnection(index) {
}

if (index < server.maxConnections) {
assert.equal(true, gotData,
index + ' didn\'t get data, but should have');
assert.strictEqual(true, gotData,
`${index} didn't get data, but should have`);
} else {
assert.equal(false, gotData,
index + ' got data, but shouldn\'t have');
assert.strictEqual(false, gotData,
`${index} got data, but shouldn't have`);
}
});
});
Expand All @@ -86,5 +82,5 @@ function makeConnection(index) {


process.on('exit', function() {
assert.equal(N, closes);
assert.strictEqual(N, closes);
});